Repository navigation
perf(artifacts): artifacts list reads mtimes in batches and formats times without date (CC-698, refs #749) - #789
Merged
Merged
Conversation
…imes without date (CC-698, refs #749) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ESW7P9wHJRbhxx3v7XyQuq
…and a non-UTC TZ (CC-698, refs #749) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ESW7P9wHJRbhxx3v7XyQuq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pmctl artifacts liststartedbasename,date, severalstatand command-substitution subshells for every run; on native Windows that is about 0.18 s per run (perf(artifacts): Windows 列出數十筆 run 約需一分鐘，需批次 metadata／時間格式化 #749). It now reads all mtimes instatcalls of 50 paths, formats times with bash'sprintf '%(...)T'(falling back todateonly if the builtin fails) and takes the run id with parameter expansion. Sorting, the time source (newest top-level footer, else the run directory) and the output format are unchanged.docs/platform-support.mdnote for CC-697 (large diffs: scope manifest cost,scan_stopped_early, the accepting rerun scans again) and recordspr:#788on CC-697, per the rule that docs ride with a ticket PR.Refs #749 (stays open: no
--limit, no 1000-run point, no process counts, no Linux/WSL run).Measurement (native Windows, same fixture, wall-clock,
cmpof old and new output identical at every size)The fixture mixes runs with no footer, two footers and equal timestamps. The "before" numbers come from
git archive HEADof the parent commit, run against the same state root.Verification
bash tests/shell/test-pmctl-artifacts.sh: 45 passed, 0 failed, 3 skipped (no real symlinks / noflockon this platform).Review (commands/ship.md Step 2.5)
Step 2.5: the old per-run helpers
pmctl_artifacts_run_created_epochand thedate-onlypmctl_artifacts_epoch_to_tswere used only by the list; the first is removed and the second now setsREPLY.pmctl_artifacts_file_mtimestays forgc.No
pr-gateround was run on this PR.Permanent test admissions:
pmctl artifacts list: batched mtimes keep footer, directory and tie semanticsis a new permanent test. It pins behaviour the batching could silently change (120 runs, more than one stat batch of 50, newest of two footers, a footer-less run taking its directory's time, UTC formatting) and no existing case covers more than two runs.🤖 Generated with Claude Code
https://claude.ai/code/session_01ESW7P9wHJRbhxx3v7XyQuq